Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App] Automate missing requirements installation for CLI #15198

Merged
merged 32 commits into from
Oct 20, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 19, 2022

What does this PR do?

This PR adds support for installing ClientCommand requirements when missing.

This is done during the connect phase. If the user provides --yes, it is automatically installed.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 19, 2022
@tchaton tchaton self-assigned this Oct 19, 2022
@tchaton tchaton marked this pull request as ready for review October 19, 2022 19:15
@tchaton tchaton added this to the v1.8 milestone Oct 19, 2022
@tchaton tchaton changed the title Automate missing requirements installation for CLI [App] Automate missing requirements installation for CLI Oct 19, 2022
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion 😃

src/lightning_app/cli/commands/app_commands.py Outdated Show resolved Hide resolved
@Borda Borda requested a review from ethanwharris October 20, 2022 11:42
@mergify mergify bot removed the has conflicts label Oct 20, 2022
@Borda Borda removed this from the v1.8 milestone Oct 20, 2022
@mergify mergify bot removed the has conflicts label Oct 20, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 20, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Oct 20, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 20, 2022
Base automatically changed from support_help to master October 20, 2022 17:45
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Oct 20, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 20, 2022
@tchaton tchaton enabled auto-merge (squash) October 20, 2022 19:01
@lexierule lexierule disabled auto-merge October 20, 2022 19:02
@lexierule lexierule merged commit 6a72a15 into master Oct 20, 2022
@lexierule lexierule deleted the install_missing_dependencies branch October 20, 2022 19:02
@carmocca carmocca modified the milestones: future, v1.8 Oct 20, 2022
@tchaton tchaton added the bug Something isn't working label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants