Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move warning before deepcopying the hyperparameters #15132

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 13, 2022

What does this PR do?

Fixes #15131

Suggestion welcome for a meaningful test

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 13, 2022
@awaelchli awaelchli added bug Something isn't working and removed pl Generic label for PyTorch Lightning package labels Oct 13, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Oct 13, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 13, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs a test.

@awaelchli awaelchli marked this pull request as ready for review October 13, 2022 21:39
@awaelchli awaelchli self-assigned this Oct 17, 2022
@awaelchli awaelchli changed the title Move warning before the deepcopy-ing the hyperparameters Move warning before deepcopying the hyperparameters Oct 18, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 19, 2022
@awaelchli awaelchli merged commit 2d3db64 into master Oct 19, 2022
@awaelchli awaelchli deleted the bugfix/warning-before-deepcopy branch October 19, 2022 10:26
@awaelchli awaelchli modified the milestones: v1.8.x, v1.8 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Raise warning about saving nn.Module in save_hyperparameters earlier
5 participants