Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate tuning enum and trainer properties #15100

Merged
merged 17 commits into from
Oct 13, 2022
Merged

Deprecate tuning enum and trainer properties #15100

merged 17 commits into from
Oct 13, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Oct 12, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Part of #11012
Addresses: #11089 (comment)

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @akihironitta @Borda @rohitgr7 @tchaton

@rohitgr7 rohitgr7 added tuner deprecation Includes a deprecation labels Oct 12, 2022
@rohitgr7 rohitgr7 added this to the v1.8 milestone Oct 12, 2022
@rohitgr7 rohitgr7 self-assigned this Oct 12, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 12, 2022
@rohitgr7 rohitgr7 linked an issue Oct 12, 2022 that may be closed by this pull request
[RFC] Tuner Revamp #11012
Closed
@rohitgr7 rohitgr7 marked this pull request as ready for review October 12, 2022 12:01
otaj
otaj previously approved these changes Oct 12, 2022
View reviewed changes
@otaj otaj dismissed their stale review October 12, 2022 12:25

So many tests are failing...

@rohitgr7
Copy link
Contributor Author

So many tests are failing...

yeah, forgot to remove the breakpoints.. 😅

justusschock
justusschock approved these changes Oct 12, 2022
View reviewed changes
src/pytorch_lightning/trainer/states.py Outdated Show resolved Hide resolved
src/pytorch_lightning/trainer/states.py Outdated Show resolved Hide resolved
src/pytorch_lightning/trainer/states.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 marked this pull request as draft October 12, 2022 13:32
@rohitgr7 rohitgr7 marked this pull request as ready for review October 12, 2022 13:51
@rohitgr7 rohitgr7 requested a review from otaj October 12, 2022 14:47
@mergify mergify bot added the ready PRs ready to be merged label Oct 12, 2022
@rohitgr7 rohitgr7 requested a review from awaelchli October 12, 2022 17:57
awaelchli
awaelchli approved these changes Oct 13, 2022
View reviewed changes
src/pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
src/pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
tests/tests_pytorch/core/test_datamodules.py Outdated Show resolved Hide resolved
carmocca
carmocca approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up!

tests/tests_pytorch/trainer/connectors/test_checkpoint_connector.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 13, 2022 12:48
@rohitgr7 rohitgr7 merged commit eb17dc9 into master Oct 13, 2022
@rohitgr7 rohitgr7 deleted the dep/tuning branch October 13, 2022 13:29
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
@rohitgr7 @nicolai86
Deprecate tuning enum and trainer properties (#15100)
a4f8e90
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
@rohitgr7 @nicolai86
Deprecate tuning enum and trainer properties (#15100)
8fe1f7e
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
@rohitgr7 @nicolai86
Deprecate tuning enum and trainer properties (#15100)
3d5cb63
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
@rohitgr7 @nicolai86
Deprecate tuning enum and trainer properties (#15100)
6ed476c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@carmocca carmocca carmocca approved these changes

@otaj otaj otaj approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@akihironitta akihironitta Awaiting requested review from akihironitta

Assignees

@rohitgr7 rohitgr7

Labels
deprecation Includes a deprecation pl Generic label for PyTorch Lightning package ready PRs ready to be merged tuner
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

[RFC] Tuner Revamp
5 participants
@rohitgr7 @awaelchli @otaj @carmocca @justusschock