-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate SRUN variables when launching in SLURM #15011
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
awaelchli
commented
Oct 5, 2022
for more information, see https://pre-commit.ci
…eature/slurm-srun-check
awaelchli
requested review from
carmocca,
justusschock and
rohitgr7
as code owners
October 17, 2022 13:40
justusschock
approved these changes
Oct 17, 2022
carmocca
approved these changes
Oct 18, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #15011 +/- ##
=========================================
+ Coverage 82% 84% +2%
=========================================
Files 412 288 -124
Lines 30265 21962 -8303
=========================================
- Hits 24869 18494 -6375
+ Misses 5396 3468 -1928 |
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Oct 19, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
environment: slurm
fabric
lightning.fabric.Fabric
feature
Is an improvement or enhancement
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses suggestion in #14986, frequent user errors that result in their SLURM jobs hanging. By adding warnings and errors, we can prevent these frequent questions and give feedback directly at runtime.
Fixes #10150
No intended breaking changes:
srun
program is only installed on SLURM clusters. However, we won't make it an error just in case there is another program calledsrun
on your system unrelated to SLURM.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @awaelchli @carmocca @justusschock