Added support for custom parameters in subclasses of SaveConfigCallback #14998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements suggestion in #14628 (comment). Does not close that issue, but it makes it possible for people to implement by themselves.
This has the benefits that:
SaveConfigCallback
and inLightningCLI.__init__
.SaveConfigCallback
adding new parameters, and allow these be given onLightningCLI
instantiation.Currently the save of the config is not even mentioned in the docs. The pull requests #14976 adds it. Could be that this is added to the docs in that pull request.
Does your PR introduce any breaking changes? If yes, please list them.
SaveConfigCallback
parameters inLightningCLI
instantiation must now be given insave_config_kwargs
, and makingsave_config_kwargs
,save_config_overwrite
andsave_config_multifile
deprecated.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃