Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App/Feature] HTTP Queues #14978

Merged
merged 50 commits into from
Oct 6, 2022
Merged

[App/Feature] HTTP Queues #14978

merged 50 commits into from
Oct 6, 2022

Conversation

hhsecond
Copy link
Contributor

@hhsecond hhsecond commented Oct 3, 2022

What does this PR do?

Introducing HTTPQueues to Lightning. This brings in the new HTTPQueue class and the HTTPClient classes. It also makes changes to the cloud dispatcher to pass the queue type. The queue type is defaults to "redis" but for those who wants to use HTTPQueue can set the environmental variable for that. Once the HTTPQueue is stabilized, we'll swap the default to HTTPQueue

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 3, 2022
@hhsecond hhsecond changed the title [APP/Feature] HTTP Queues [App/Feature] HTTP Queues Oct 3, 2022
@hhsecond hhsecond mentioned this pull request Oct 3, 2022
12 tasks
@hhsecond hhsecond self-assigned this Oct 6, 2022
@hhsecond hhsecond added this to the app:0.6.x milestone Oct 6, 2022
@hhsecond hhsecond modified the milestones: app:0.6.x, app:0.7 Oct 6, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

src/lightning_app/core/queues.py Show resolved Hide resolved
src/lightning_app/core/queues.py Outdated Show resolved Hide resolved
src/lightning_app/core/queues.py Show resolved Hide resolved
@Borda Borda modified the milestones: app:0.6.x, app:0.7 Oct 6, 2022
Copy link
Contributor

@manskx manskx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mergify mergify bot added the ready PRs ready to be merged label Oct 6, 2022
@hhsecond hhsecond merged commit 129f4fa into master Oct 6, 2022
@hhsecond hhsecond deleted the feature/http-queue-abs branch October 6, 2022 10:31
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
[App/Feature] HTTP Queues (#14978)
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
[App/Feature] HTTP Queues (#14978)
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
[App/Feature] HTTP Queues (#14978)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants