Close profiler when `StopIteration` is raised #14945

ziyadsheeba · 2022-09-29T13:34:02Z

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

for more information, see https://pre-commit.ci

src/pytorch_lightning/utilities/fetching.py

for more information, see https://pre-commit.ci

…sing

awaelchli

Great test! Checked it fails without the change.

An entry in the fixed section of the changelog would be the cherry on top.

…sing

* use more recent lightning cloud launcher * allow LightningApp to use custom cloud compute for flows * feedback from adrian * adjust other cloud tests * update * update * update commens * Update src/lightning_app/core/app.py Co-authored-by: Sherin Thomas <[email protected]> * Close profiler when `StopIteration` is raised (#14945) * Find last checkpoints on restart (#14907) Co-authored-by: Carlos Mocholí <[email protected]> * Remove unused gcsfs dependency (#14962) * Update hpu mixed precision link (#14974) Signed-off-by: Jerome <[email protected]> * Bump version of fsspec (#14975) fsspec verbump * Fix TPU test CI (#14926) * Fix TPU test CI * +x first * Lite first to uncovert errors faster * Fixes * One more * Simplify XLALauncher wrapping to avoid pickle error * debug * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Debug commit successful. Trying local definitions * Require tpu for mock test * ValueError: The number of devices must be either 1 or 8, got 4 instead * Fix mock test * Simplify call, rely on defaults * Skip OSError for now. Maybe upgrading will help * Simplify launch tests, move some to lite * Stricter typing * RuntimeError: Accessing the XLA device before processes have spawned is not allowed. * Revert "RuntimeError: Accessing the XLA device before processes have spawned is not allowed." This reverts commit f65107e. * Alternative boring solution to the reverted commit * Fix failing test on CUDA machine * Workarounds * Try latest mkl * Revert "Try latest mkl" This reverts commit d06813a. * Wrong exception * xfail * Mypy * Comment change * Spawn launch refactor * Accept that we cannot lazy init now * Fix mypy and launch test failures * The base dockerfile already includes mkl-2022.1.0 - what if we use it? * try a different mkl version * Revert mkl version changes Co-authored-by: awaelchli <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Akihiro Nitta <[email protected]> * Trainer: fix support for non-distributed PyTorch (#14971) * Trainer: fix non-distributed use * Update CHANGELOG * fixes typing errors in rich_progress.py (#14963) * revert default cloud compute rename * allow LightningApp to use custom cloud compute for flows * feedback from adrian * update * resolve merge with master conflict * remove preemptible * update CHANGELOG * add basic flow cloud compute documentation * fix docs build * add missing symlink * try to fix sphinx * another attempt for docs * fix new test Signed-off-by: Jerome <[email protected]> Co-authored-by: thomas chaton <[email protected]> Co-authored-by: Sherin Thomas <[email protected]> Co-authored-by: Ziyad Sheebaelhamd <[email protected]> Co-authored-by: otaj <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jerome Anand <[email protected]> Co-authored-by: awaelchli <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Akihiro Nitta <[email protected]> Co-authored-by: Adam J. Stewart <[email protected]> Co-authored-by: DP <[email protected]>

Handled profiler closing upon StopIteration being raised

37f8f3f

ziyadsheeba requested review from Borda, tchaton and carmocca as code owners September 29, 2022 13:34

github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 29, 2022

ziyadsheeba marked this pull request as draft September 29, 2022 13:42

ziyadsheeba and others added 4 commits September 29, 2022 15:48

Handled StopIteration exception more explicitly

a8ee54f

removed mistakenly added import

61e41f5

[pre-commit.ci] auto fixes from pre-commit.com hooks

143b12f

for more information, see https://pre-commit.ci

removed diskcache import

5659743

carmocca reviewed Sep 29, 2022

View reviewed changes

src/pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved

carmocca added bug Something isn't working data handling Generic data-related topic community This PR is from the community labels Sep 29, 2022

ziyadsheeba and others added 3 commits September 30, 2022 09:15

wrapping only next(iterator) in a try/except

d9277e2

Added test to ensure profiler closing

74f2d7a

[pre-commit.ci] auto fixes from pre-commit.com hooks

9832f22

for more information, see https://pre-commit.ci

ziyadsheeba marked this pull request as ready for review September 30, 2022 09:28

ziyadsheeba requested review from awaelchli, rohitgr7, otaj and justusschock as code owners September 30, 2022 09:28

ziyadsheeba and others added 2 commits September 30, 2022 11:29

Merge branch 'master' into bugfix/14940_iterable-dataset-profiler-clo…

229a7f9

…sing

removed unnecessary iter call in test

750633e

awaelchli approved these changes Sep 30, 2022

View reviewed changes

carmocca approved these changes Sep 30, 2022

View reviewed changes

carmocca added this to the pl:1.7.x milestone Sep 30, 2022

carmocca self-assigned this Sep 30, 2022

mergify bot added the ready PRs ready to be merged label Sep 30, 2022

Merge branch 'master' into bugfix/14940_iterable-dataset-profiler-clo…

141d7ff

…sing

ziyadsheeba added 4 commits September 30, 2022 15:41

Update CHANGELOG.md

880c9d7

Update CHANGELOG.md

697e0e2

Update CHANGELOG.md

034ec12

Merge branch 'master' into bugfix/14940_iterable-dataset-profiler-clo…

95a6d5b

…sing

carmocca enabled auto-merge (squash) September 30, 2022 15:02

carmocca disabled auto-merge September 30, 2022 15:02

carmocca enabled auto-merge (squash) September 30, 2022 15:02

carmocca changed the title ~~Handled profiler closing upon StopIteration being raised~~ Close profiler when StopIteration is raised Sep 30, 2022

Merge branch 'master' into bugfix/14940_iterable-dataset-profiler-clo…

447258d

…sing

justusschock approved these changes Sep 30, 2022

View reviewed changes

Merge branch 'master' into bugfix/14940_iterable-dataset-profiler-clo…

2119a18

…sing

carmocca merged commit db26e08 into Lightning-AI:master Sep 30, 2022

nicolai86 pushed a commit that referenced this pull request Oct 3, 2022

Close profiler when StopIteration is raised (#14945)

028ea0a

nicolai86 pushed a commit that referenced this pull request Oct 13, 2022

Close profiler when StopIteration is raised (#14945)

5c55109

nicolai86 pushed a commit that referenced this pull request Oct 13, 2022

Close profiler when StopIteration is raised (#14945)

b67d2f6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Close profiler when `StopIteration` is raised #14945

Close profiler when `StopIteration` is raised #14945

ziyadsheeba commented Sep 29, 2022 •

edited

Loading

awaelchli left a comment

Close profiler when StopIteration is raised #14945

Close profiler when StopIteration is raised #14945

Conversation

ziyadsheeba commented Sep 29, 2022 • edited Loading

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

awaelchli left a comment

Choose a reason for hiding this comment

Close profiler when `StopIteration` is raised #14945

Close profiler when `StopIteration` is raised #14945

ziyadsheeba commented Sep 29, 2022 •

edited

Loading