Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid initializing optimizers during deepspeed evaluation #14944

Merged
merged 8 commits into from
Oct 21, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Sep 29, 2022

What does this PR do?

Fixes #14928
Fixes: #10640

Support was added here: microsoft/DeepSpeed#1514
And it's in v0.6.0 which is the minimum we support: microsoft/DeepSpeed@v0.5.6...v0.6.0

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @awaelchli @rohitgr7 @akihironitta

@rohitgr7 rohitgr7 self-assigned this Sep 29, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 29, 2022
@rohitgr7 rohitgr7 added this to the pl:1.7.x milestone Sep 29, 2022
@rohitgr7 rohitgr7 added strategy: deepspeed bug Something isn't working labels Sep 29, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review September 29, 2022 18:49
@rohitgr7 rohitgr7 added this to the v1.8 milestone Oct 21, 2022
@rohitgr7 rohitgr7 modified the milestones: v1.8, pl:1.7.x Oct 21, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review October 21, 2022 11:32
@mergify mergify bot removed the has conflicts label Oct 21, 2022
@carmocca carmocca modified the milestones: pl:1.7.x, v1.8 Oct 21, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 21, 2022
@rohitgr7 rohitgr7 requested review from awaelchli and removed request for DrMatters October 21, 2022 12:40
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Oct 21, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 21, 2022
@rohitgr7 rohitgr7 merged commit 0a729f6 into master Oct 21, 2022
@rohitgr7 rohitgr7 deleted the fix/deepspeed_inference branch October 21, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: deepspeed
Projects
No open projects
Status: Done
5 participants