Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MissingFieldException in offline mode #14919

Merged
merged 17 commits into from
Sep 29, 2022

Conversation

Blaizzy
Copy link
Contributor

@Blaizzy Blaizzy commented Sep 28, 2022

What does this PR do?

It fixes MissingFieldException in offline mode reported here: neptune-ai/neptune-client#893

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yes, I did 😃 !

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 28, 2022
@carmocca carmocca added bug Something isn't working logger: neptune labels Sep 28, 2022
@carmocca carmocca added this to the pl:1.8 milestone Sep 28, 2022
src/pytorch_lightning/loggers/neptune.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Sep 28, 2022
src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
src/pytorch_lightning/loggers/neptune.py Show resolved Hide resolved
tests/tests_pytorch/loggers/test_neptune.py Outdated Show resolved Hide resolved
@awaelchli awaelchli enabled auto-merge (squash) September 29, 2022 18:44
@awaelchli awaelchli merged commit 04aaf83 into Lightning-AI:master Sep 29, 2022
@Blaizzy Blaizzy deleted the pc/fix-offline-error branch September 30, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logger: neptune pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants