Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the deprecated datamodule_checkpointhooks #14909

Merged
merged 10 commits into from
Sep 29, 2022

Conversation

NeoKish
Copy link
Contributor

@NeoKish NeoKish commented Sep 27, 2022

What does this PR do?

Remove deprecate API

Part of #14841
resolves #11887

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 27, 2022
@awaelchli awaelchli added breaking change Includes a breaking change lightningdatamodule pl.LightningDataModule labels Sep 27, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 27, 2022
@awaelchli
Copy link
Contributor

@NeoKish Thanks for the PR. The actual removal of what was deprecated was missing. It probably wasn't very clear of what should have been done, so I figured I push a commit to help you out, hope that's ok. Waiting for tests to pass.

Nice work!

@mergify mergify bot added the ready PRs ready to be merged label Sep 27, 2022
src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
@awaelchli awaelchli enabled auto-merge (squash) September 28, 2022 09:08
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 29, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 29, 2022
@awaelchli awaelchli merged commit 1e5411b into Lightning-AI:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change lightningdatamodule pl.LightningDataModule pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants