-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the deprecated datamodule_checkpointhooks #14909
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoKish
requested review from
williamFalcon,
Borda,
tchaton,
carmocca,
awaelchli,
justusschock,
kaushikb11,
rohitgr7 and
otaj
as code owners
September 27, 2022 16:14
for more information, see https://pre-commit.ci
23 tasks
awaelchli
added
breaking change
Includes a breaking change
lightningdatamodule
pl.LightningDataModule
labels
Sep 27, 2022
@NeoKish Thanks for the PR. The actual removal of what was deprecated was missing. It probably wasn't very clear of what should have been done, so I figured I push a commit to help you out, hope that's ok. Waiting for tests to pass. Nice work! |
awaelchli
approved these changes
Sep 27, 2022
carmocca
approved these changes
Sep 27, 2022
otaj
approved these changes
Sep 28, 2022
Co-authored-by: otaj <[email protected]>
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Sep 29, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
lightningdatamodule
pl.LightningDataModule
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove deprecate API
Part of #14841
resolves #11887
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃