Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comet.ml logger - add usage tracking #14906

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Comet.ml logger - add usage tracking #14906

merged 4 commits into from
Sep 29, 2022

Conversation

alexkuzmik
Copy link
Contributor

@alexkuzmik alexkuzmik commented Sep 27, 2022 •
edited by carmocca
Loading

What does this PR do?

Fixes #14905

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 27, 2022
@awaelchli awaelchli added feature Is an improvement or enhancement logger: comet labels Sep 27, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 27, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 28, 2022
@otaj otaj enabled auto-merge (squash) September 28, 2022 08:13
auto-merge was automatically disabled September 28, 2022 13:01

Head branch was pushed to by a user without write access

@awaelchli awaelchli enabled auto-merge (squash) September 28, 2022 13:50
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 29, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 29, 2022
@awaelchli awaelchli merged commit 4c43e57 into Lightning-AI:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@akihironitta akihironitta akihironitta approved these changes

@carmocca carmocca carmocca approved these changes

@otaj otaj otaj approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
feature Is an improvement or enhancement logger: comet pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

Add framework usage tracking for pytorch lightning comet.ml logger
5 participants
@alexkuzmik @awaelchli @otaj @carmocca @akihironitta