Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated device_stats_monitor.prefix_keys #14890

Merged
merged 9 commits into from
Oct 3, 2022
Merged

Remove the deprecated device_stats_monitor.prefix_keys #14890

merged 9 commits into from
Oct 3, 2022

Conversation

NeoKish
Copy link
Contributor

@NeoKish NeoKish commented Sep 25, 2022 •
edited by Borda
Loading

What does this PR do?

Removes deprecated API.

resolves #11254

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 25, 2022
@rohitgr7 rohitgr7 added breaking change Includes a breaking change callback: device stats community This PR is from the community labels Sep 25, 2022
@rohitgr7 rohitgr7 added this to the pl:1.8 milestone Sep 25, 2022
@rohitgr7 rohitgr7 mentioned this pull request Sep 25, 2022
Closed
23 tasks
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Sep 25, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 28, 2022
tchaton
tchaton approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 29, 2022
@akihironitta akihironitta enabled auto-merge (squash) September 30, 2022 08:27
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 30, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 30, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 3, 2022
@akihironitta akihironitta merged commit c059db4 into Lightning-AI:master Oct 3, 2022
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
@NeoKish @pre-commit-ci
@otaj @carmocca @akihironitta @nicolai86
Remove the deprecated device_stats_monitor_prefix_keys (#14890)
826152f 
* Remove the deprecated device_stats_monitor_prefix_keys

* Added pr no to changelog.md

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: otaj <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
@Borda Borda changed the title Remove the deprecated device_stats_monitor_prefix_keys Remove the deprecated device_stats_monitor_prefix_keys Mar 9, 2023
@Borda Borda changed the title Remove the deprecated device_stats_monitor_prefix_keys Remove the deprecated device_stats_monitor.prefix_keys Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@akihironitta akihironitta akihironitta approved these changes

@tchaton tchaton tchaton approved these changes

@carmocca carmocca carmocca approved these changes

@otaj otaj otaj approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
breaking change Includes a breaking change callback: device stats community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
7 participants
@NeoKish @awaelchli @otaj @carmocca @tchaton @akihironitta @rohitgr7