Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix connect/ disconnect without arguments #14877

Merged
merged 4 commits into from
Sep 27, 2022

Conversation

nicolai86
Copy link
Contributor

@nicolai86 nicolai86 commented Sep 24, 2022

What does this PR do?

This PR fixes an error that occurs when the lightning CLI is used without arguments.
It seems this was introduced in #14183.

Fixes #14875

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Sep 24, 2022
@nicolai86 nicolai86 mentioned this pull request Sep 24, 2022
5 tasks
@nicolai86 nicolai86 added this to the app:0.6.x milestone Sep 24, 2022
@nicolai86 nicolai86 force-pushed the nicolai86/fix-lightning-wo-args branch from 993fdca to 56acb39 Compare September 24, 2022 00:42
@nicolai86 nicolai86 marked this pull request as ready for review September 24, 2022 02:19
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli added the bug Something isn't working label Sep 24, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 24, 2022
@awaelchli awaelchli enabled auto-merge (squash) September 24, 2022 09:52
@awaelchli awaelchli merged commit 6edf5c5 into master Sep 27, 2022
@awaelchli awaelchli deleted the nicolai86/fix-lightning-wo-args branch September 27, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lightning CLI argument fails
3 participants