Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated run_stage #14870

Merged
merged 3 commits into from
Sep 24, 2022
Merged

Remove the deprecated run_stage #14870

merged 3 commits into from
Sep 24, 2022

Conversation

AndresAlgaba
Copy link
Contributor

@AndresAlgaba AndresAlgaba commented Sep 23, 2022 •
edited by Borda
Loading

What does this PR do?

Removes deprecated APIs for 1.8 release, #14841. More specifically, the removal of test_v1_8_0_deprecated_run_stage.

resolves #11000

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 23, 2022
@AndresAlgaba AndresAlgaba changed the title Rremove the deprecated run_stage Remove the deprecated run_stage Sep 23, 2022
@AndresAlgaba AndresAlgaba marked this pull request as ready for review September 23, 2022 12:37
@carmocca carmocca added this to the pl:1.8 milestone Sep 23, 2022
@carmocca carmocca added the breaking change Includes a breaking change label Sep 23, 2022
@krishnakalyan3 krishnakalyan3 mentioned this pull request Sep 23, 2022
Closed
23 tasks
@mergify mergify bot added the ready PRs ready to be merged label Sep 23, 2022
@Borda Borda enabled auto-merge (squash) September 23, 2022 22:11
@Borda Borda merged commit a648934 into Lightning-AI:master Sep 24, 2022
@AndresAlgaba AndresAlgaba deleted the feature/remove/deprecated_run_stage branch September 24, 2022 18:15
rohitgr7
rohitgr7 reviewed Sep 24, 2022
View reviewed changes
src/pytorch_lightning/CHANGELOG.md
@@ -221,6 +221,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

- Removed the deprecated `Trainer.use_amp` and `LightningModule.use_amp` attributes ([#14832](https://github.com/Lightning-AI/lightning/pull/14832))

- Removed the deprecated `Trainer.run_stage` in favor of `Trainer.{fit,validate,test,predict}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I missed it but why no one is adding the PR link for these PRs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! I believe we forgot this. Should I open a new PR to add this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this in another PR :)

@awaelchli awaelchli mentioned this pull request Oct 10, 2022
Merged
11 tasks
@Borda Borda changed the title Remove the deprecated run_stage Remove the deprecated run_stage Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@otaj otaj Awaiting requested review from otaj

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
breaking change Includes a breaking change pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@AndresAlgaba @Borda @carmocca @rohitgr7