Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated call_hook #14869

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Remove deprecated call_hook #14869

merged 4 commits into from
Sep 26, 2022

Conversation

AndresAlgaba
Copy link
Contributor

@AndresAlgaba AndresAlgaba commented Sep 23, 2022

What does this PR do?

Removes deprecated APIs for 1.8 release, #14841. More specifically, the removal of test_v1_8_0_deprecated_call_hook.

resolves #10979

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 23, 2022
@awaelchli awaelchli added the breaking change Includes a breaking change label Sep 26, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 26, 2022
@awaelchli awaelchli added the community This PR is from the community label Sep 26, 2022
@mergify mergify bot removed the has conflicts label Sep 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 26, 2022
@carmocca carmocca merged commit 4fc8275 into Lightning-AI:master Sep 26, 2022
@Borda Borda changed the title Remove deprecated call_hook Remove deprecated call_hook Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants