Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attribute error in SWA when running with Tuner #14836

Merged
merged 5 commits into from
Sep 22, 2022
Merged

Fix attribute error in SWA when running with Tuner #14836

merged 5 commits into from
Sep 22, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 21, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #14755

This issue was likely introduces with the typing changes in #13685

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @akihironitta @Borda @rohitgr7 @carmocca

@awaelchli awaelchli added bug Something isn't working tuner callback: swa labels Sep 21, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 21, 2022
@awaelchli awaelchli self-assigned this Sep 21, 2022
@awaelchli awaelchli added this to the pl:1.7.x milestone Sep 21, 2022
@awaelchli awaelchli marked this pull request as ready for review September 21, 2022 23:22
carmocca
carmocca approved these changes Sep 21, 2022
View reviewed changes
tests/tests_pytorch/tuner/test_lr_finder.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Sep 22, 2022
@Borda Borda enabled auto-merge (squash) September 22, 2022 07:05
@Borda Borda merged commit 31788db into master Sep 22, 2022
@Borda Borda deleted the bugfix/tuner-with-swa branch September 22, 2022 07:10
rohitgr7 pushed a commit that referenced this pull request Sep 24, 2022
@awaelchli @pre-commit-ci @rohitgr7
Fix attribute error in SWA when running with Tuner (#14836)
a3acbb7 
* Fix attribute error in SWA when running with Tuner
* changelog
* add better test

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@otaj otaj Awaiting requested review from otaj

Assignees

@awaelchli awaelchli

Labels
bug Something isn't working callback: swa pl Generic label for PyTorch Lightning package ready PRs ready to be merged tuner
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
pl:1.7.x
Development

Successfully merging this pull request may close these issues.

auto_tune_lr + StochasticWeightAveraging returns error
3 participants
@awaelchli @Borda @carmocca