-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated on_load/save_checkpoint
behavior
#14835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
callback
deprecation
Includes a deprecation
breaking change
Includes a breaking change
labels
Sep 21, 2022
23 tasks
awaelchli
requested review from
williamFalcon,
tchaton,
carmocca,
rohitgr7,
otaj,
justusschock and
Borda
as code owners
October 10, 2022 08:43
2 tasks
justusschock
approved these changes
Oct 10, 2022
11 tasks
carmocca
approved these changes
Oct 10, 2022
11 tasks
nicolai86
pushed a commit
that referenced
this pull request
Oct 13, 2022
Co-authored-by: Jirka Borovec <[email protected]>
Borda
changed the title
Remove deprecated on_load/save_checkpoint behavior
Remove deprecated Mar 9, 2023
on_load/save_checkpoint
behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
callback
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes deprecated behavior around the
Callback.on_save_checkpoint
andCallback.on_load_checkpoint
hooks.Part of #14841
Part of #15049
resolves #11887
Converted all deprecation warnings to errors.
Per recent decision, we will extend our deprecation window in the following way:
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @awaelchli @ananthsub @rohitgr7 @Borda @justusschock