Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated on_load/save_checkpoint behavior #14835

Merged
merged 13 commits into from
Oct 10, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 21, 2022

What does this PR do?

Removes deprecated behavior around the Callback.on_save_checkpoint and Callback.on_load_checkpoint hooks.

Part of #14841
Part of #15049

resolves #11887

Converted all deprecation warnings to errors.

Per recent decision, we will extend our deprecation window in the following way:

  • Deprecate API in v1.x with a warning for removal in v1.(x+2)
  • Remove API in v1.(x+2) and convert warnings to errors
  • Remove errors for removed APIs in v2.0

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @awaelchli @ananthsub @rohitgr7 @Borda @justusschock

@awaelchli awaelchli self-assigned this Sep 21, 2022
@awaelchli awaelchli added callback deprecation Includes a deprecation breaking change Includes a breaking change labels Sep 21, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 21, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 21, 2022
@carmocca carmocca removed the deprecation Includes a deprecation label Sep 22, 2022
@awaelchli awaelchli marked this pull request as ready for review October 10, 2022 08:43
@awaelchli awaelchli mentioned this pull request Oct 10, 2022
11 tasks
@mergify mergify bot added the ready PRs ready to be merged label Oct 10, 2022
@awaelchli awaelchli enabled auto-merge (squash) October 10, 2022 10:54
@awaelchli awaelchli merged commit 8f90084 into master Oct 10, 2022
@awaelchli awaelchli deleted the feature/remove/callback-checkpoint-hooks branch October 10, 2022 11:08
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
@Borda Borda changed the title Remove deprecated on_load/save_checkpoint behavior Remove deprecated on_load/save_checkpoint behavior Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change callback pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants