Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated callback hooks #14834

Merged
merged 46 commits into from
Oct 10, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 21, 2022

What does this PR do?

Removes deprecated API.
Converted all deprecation warnings to errors.

Per recent decision, we will extend our deprecation window in the following way:

  • Deprecate API in v1.x with a warning for removal in v1.(x+2)
  • Remove API in v1.(x+2) and convert warnings to errors
  • Remove errors for removed APIs in v2.0

Closes #14841
Part of #15049

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @awaelchli @ananthsub @rohitgr7 @justusschock @carmocca @ninginthecloud

@awaelchli awaelchli added deprecation Includes a deprecation breaking change Includes a breaking change callback labels Sep 21, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 21, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 21, 2022
@awaelchli awaelchli self-assigned this Sep 21, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Sep 21, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished up the removal. Didn't run tests though

examples/app_components/python/component_tracer.py Outdated Show resolved Hide resolved
@carmocca carmocca removed the deprecation Includes a deprecation label Sep 22, 2022
@awaelchli
Copy link
Contributor Author

@lantiga I created this issue that summarizes the new plan we discussed offline #15049. PR #14835 would be the first to implement this pattern and then we follow with this one here. Further PRs will then bring back partially what was removed here: #14841

@awaelchli awaelchli marked this pull request as draft October 10, 2022 09:34
auto-merge was automatically disabled October 10, 2022 09:34

Pull request was converted to draft

@awaelchli awaelchli marked this pull request as ready for review October 10, 2022 11:23
@awaelchli awaelchli requested review from carmocca and removed request for Felonious-Spellfire October 10, 2022 12:18
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #14834 (7635128) into master (c04e1cd) will increase coverage by 1%.
The diff coverage is 94%.

❗ Current head 7635128 differs from pull request most recent head 498e981. Consider uploading reports for the commit 498e981 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #14834     +/-   ##
=========================================
+ Coverage      83%      84%     +1%     
=========================================
  Files         400      329     -71     
  Lines       29501    25856   -3645     
=========================================
- Hits        24432    21763   -2669     
+ Misses       5069     4093    -976     

@carmocca carmocca added the pl Generic label for PyTorch Lightning package label Oct 10, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Oct 10, 2022
@awaelchli awaelchli added the pl Generic label for PyTorch Lightning package label Oct 10, 2022
@awaelchli awaelchli enabled auto-merge (squash) October 10, 2022 14:58
@awaelchli awaelchli merged commit 3183079 into master Oct 10, 2022
@awaelchli awaelchli deleted the feature/remove/callback-hooks branch October 10, 2022 15:46
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: otaj <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change callback hooks Related to the hooks API pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Remove deprecated APIs for 1.8 release
10 participants