-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated callback hooks #14834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished up the removal. Didn't run tests though
Pull request was converted to draft
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #14834 +/- ##
=========================================
+ Coverage 83% 84% +1%
=========================================
Files 400 329 -71
Lines 29501 25856 -3645
=========================================
- Hits 24432 21763 -2669
+ Misses 5069 4093 -976 |
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: otaj <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
What does this PR do?
Removes deprecated API.
Converted all deprecation warnings to errors.
Per recent decision, we will extend our deprecation window in the following way:
Closes #14841
Part of #15049
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @awaelchli @ananthsub @rohitgr7 @justusschock @carmocca @ninginthecloud