Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated LightningIPUModule #14830

Merged
merged 10 commits into from
Sep 29, 2022
Merged

Remove deprecated LightningIPUModule #14830

merged 10 commits into from
Sep 29, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 21, 2022

What does this PR do?

Removes deprecated API.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @tchaton @rohitgr7 @Borda @justusschock @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 21, 2022
@awaelchli awaelchli added deprecation Includes a deprecation breaking change Includes a breaking change labels Sep 21, 2022
@awaelchli awaelchli self-assigned this Sep 21, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 21, 2022
@awaelchli awaelchli marked this pull request as ready for review September 21, 2022 23:26
@carmocca carmocca removed the deprecation Includes a deprecation label Sep 22, 2022
@mergify mergify bot removed the has conflicts label Sep 22, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 22, 2022
@Borda Borda enabled auto-merge (squash) September 22, 2022 08:43
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 22, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 22, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 22, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 22, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 24, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 26, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda merged commit a45c047 into master Sep 29, 2022
@Borda Borda deleted the feature/remove/ipu-module branch September 29, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: ipu (removed)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants