Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated device attributes from Trainer #14829

Merged
merged 5 commits into from
Sep 22, 2022
Merged

Remove deprecated device attributes from Trainer #14829

merged 5 commits into from
Sep 22, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 21, 2022 •
edited by Borda
Loading

What does this PR do?

Removes deprecated API.

resolves #12262 #12151 #12384 #12386 #12436 #12437

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @tchaton @rohitgr7 @Borda @justusschock @akihironitta

@awaelchli awaelchli added deprecation Includes a deprecation breaking change Includes a breaking change labels Sep 21, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 21, 2022
@awaelchli awaelchli self-assigned this Sep 21, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 21, 2022
carmocca
carmocca approved these changes Sep 21, 2022
View reviewed changes
src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
@awaelchli awaelchli marked this pull request as ready for review September 21, 2022 23:24
@carmocca carmocca removed the deprecation Includes a deprecation label Sep 22, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 22, 2022
@Borda Borda enabled auto-merge (squash) September 22, 2022 07:11
@mergify mergify bot added the ready PRs ready to be merged label Sep 22, 2022
@Borda Borda merged commit 1d3e971 into master Sep 22, 2022
@Borda Borda deleted the feature/remove/device-attrs branch September 22, 2022 10:17
rohitgr7 pushed a commit that referenced this pull request Sep 24, 2022
@awaelchli @carmocca
@Borda @rohitgr7
Remove deprecated device attributes from Trainer (#14829)
1750e93 
* Remove deprecated device attributes from Trainer
* changelog

Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
awaelchli added a commit that referenced this pull request Oct 10, 2022
@awaelchli
Revert "Remove deprecated device attributes from Trainer (#14829)"
6dc7542 
This reverts commit 1d3e971.
@awaelchli awaelchli mentioned this pull request Oct 10, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@otaj otaj otaj approved these changes

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@awaelchli awaelchli

Labels
breaking change Includes a breaking change pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@awaelchli @Borda @otaj @carmocca