Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double precision support in Lite #14827

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Fix double precision support in Lite #14827

merged 1 commit into from
Sep 27, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 21, 2022

Fixes an issue discovered in #14815 when bringing tests from PL to Lite.
Addresses the TODO left in the code.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli @akihironitta @rohitgr7

@awaelchli awaelchli changed the base branch from master to lite/integration-tests September 21, 2022 21:44
@awaelchli awaelchli added fabric lightning.fabric.Fabric feature Is an improvement or enhancement precision: double Double precision labels Sep 21, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 21, 2022
Base automatically changed from lite/integration-tests to master September 26, 2022 18:50
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 26, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Sep 26, 2022
@awaelchli awaelchli marked this pull request as ready for review September 26, 2022 19:07
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 26, 2022
@awaelchli awaelchli self-assigned this Sep 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 27, 2022
@awaelchli awaelchli enabled auto-merge (squash) September 27, 2022 08:18
@awaelchli awaelchli merged commit d572a7e into master Sep 27, 2022
@awaelchli awaelchli deleted the lite/fix-casting branch September 27, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package precision: double Double precision ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants