Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update device attribute in Lite's module wrapper #14822

Merged
merged 13 commits into from
Sep 21, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 21, 2022

What does this PR do?

Fixes #14818

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli @akihironitta

@awaelchli awaelchli added this to the pl:1.7.x milestone Sep 21, 2022
@awaelchli awaelchli added bug Something isn't working fabric lightning.fabric.Fabric labels Sep 21, 2022
@awaelchli awaelchli self-assigned this Sep 21, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 21, 2022
@awaelchli awaelchli marked this pull request as ready for review September 21, 2022 12:59
src/lightning_lite/lite.py Outdated Show resolved Hide resolved
src/lightning_lite/lite.py Outdated Show resolved Hide resolved
src/lightning_lite/lite.py Outdated Show resolved Hide resolved
tests/tests_lite/helpers/utils.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Sep 21, 2022
Co-authored-by: Carlos Mocholí <[email protected]>
@awaelchli awaelchli enabled auto-merge (squash) September 21, 2022 17:28
@awaelchli awaelchli merged commit 3f0fec5 into master Sep 21, 2022
@awaelchli awaelchli deleted the bugfix/lite-device branch September 21, 2022 19:06
@awaelchli awaelchli mentioned this pull request Sep 21, 2022
12 tasks
rohitgr7 pushed a commit that referenced this pull request Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bug of setup for SingleDeviceStrategy with LightningLite
3 participants