-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed TypeError
on 1.7.6 when torch.distributed
unavailable
#14809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaj
requested review from
Borda,
tchaton,
carmocca,
awaelchli,
justusschock and
rohitgr7
as code owners
September 20, 2022 15:56
otaj
changed the title
Fixed TypeError on 1.7.6 when
Fixed Sep 20, 2022
torch.distributed
unavailableTypeError
on 1.7.6 when torch.distributed
unavailable
5 tasks
awaelchli
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @otaj
I also have no idea how to test this
carmocca
approved these changes
Sep 20, 2022
Borda
approved these changes
Sep 20, 2022
kaushikb11
approved these changes
Sep 20, 2022
kaushikb11
pushed a commit
that referenced
this pull request
Sep 21, 2022
* Fixed TypeError on 1.7.6 when distributed unavailable * changelog
11 tasks
carmocca
pushed a commit
that referenced
this pull request
Sep 21, 2022
* Fixed TypeError on 1.7.6 when distributed unavailable * changelog
carmocca
pushed a commit
that referenced
this pull request
Sep 21, 2022
* Fixed TypeError on 1.7.6 when distributed unavailable * changelog
lexierule
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Fixed TypeError on 1.7.6 when distributed unavailable * changelog
rohitgr7
pushed a commit
that referenced
this pull request
Sep 24, 2022
* Fixed TypeError on 1.7.6 when distributed unavailable * changelog
This was referenced Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
code quality
pl
Generic label for PyTorch Lightning package
priority: 0
High priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#14454 added a subtle bug - when
torch.distributed
was not available, type ofProcessGroup
was set to...
, however it is once used insideOptional
(Optional[ProcessGroup]
). However, having anOptional
ofEllipsis
is not allowed by Python type system and results in obscureTypeError
.This was noticed in #14765 (comment)
I do not know how to properly test this. I tried to mock
torch.distributed.is_available()
andsys.modules
and importpytorch_lightning
in a test, however this did not yield expected failure on previous version.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @tchaton @rohitgr7 @akihironitta @awaelchli