Fix TensorBoardLogger creating redundant experiment when finalizing #14762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
commented
Sep 17, 2022
awaelchli
requested review from
tchaton,
Borda,
carmocca,
justusschock,
rohitgr7,
otaj,
williamFalcon and
kaushikb11
as code owners
12 tasks
Borda
approved these changes
Sep 17, 2022
krshrimali
approved these changes
Sep 18, 2022
There was a problem hiding this comment.
Thanks @awaelchli ! 2 minor nits (needed before merging I guess) and a small question (this question shouldn't block merging this PR), otherwise LGTM. 🚀
Co-authored-by: Kushashwa Ravi Shrimali <[email protected]>
Co-authored-by: Kushashwa Ravi Shrimali <[email protected]>
kaushikb11
pushed a commit
that referenced
this pull request
Sep 21, 2022
…14762) Co-authored-by: Kushashwa Ravi Shrimali <[email protected]>
carmocca
pushed a commit
that referenced
this pull request
Sep 21, 2022
…14762) Co-authored-by: Kushashwa Ravi Shrimali <[email protected]>
carmocca
pushed a commit
that referenced
this pull request
Sep 21, 2022
…14762) Co-authored-by: Kushashwa Ravi Shrimali <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Sep 22, 2022
…14762) Co-authored-by: Kushashwa Ravi Shrimali <[email protected]>
rohitgr7
pushed a commit
that referenced
this pull request
Sep 24, 2022
…14762) Co-authored-by: Kushashwa Ravi Shrimali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unblocks #12292, as I found a bug while helping out there.
The newly added test in test_tensorboard.py illustrates the issue: When nothing is logged, no experiment exists, but the call to finalize() would create a new experiment, then close it immediately again, leaving useless summary files behind.
This PR changes this to only flush/close or create directories when an experiment actually exists. This is consistent with all other loggers.
Does your PR introduce any breaking changes? If yes, please list them.
I don't think so. This was a peculiar edge case I can't believe anyone would need to rely on for a serious use case.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @awaelchli @edward-io @rohitgr7 @akihironitta