-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated NeptuneLogger
code
#14727
Conversation
@Blaizzy Do you want to have a quick look here before we merge? 😃 |
@awaelchli yes, I would like that. |
I left a few comments and will also be calling in someone from engineering to double-check the test cases. But outside of that, I think it looks good. Next steps: |
@awaelchli, the review is done 👍 Any questions about the changes requested, please tag me and @shnela directly. We are here to help you with anything you might need. |
What does this PR do?
This should have been removed last release, but was missed.
I hope I did this correctly. Please take a look, Neptune devs.
Unblocks #14715
Does your PR introduce any breaking changes? If yes, please list them.
Removes deprecated code.
Before submitting
PR review
cc @Blaizzy