Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated NeptuneLogger code #14727

Merged
merged 4 commits into from
Sep 16, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 15, 2022

What does this PR do?

This should have been removed last release, but was missed.

I hope I did this correctly. Please take a look, Neptune devs.

Unblocks #14715

Does your PR introduce any breaking changes? If yes, please list them.

Removes deprecated code.

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Blaizzy

@carmocca carmocca added this to the pl:1.8 milestone Sep 15, 2022
@carmocca carmocca self-assigned this Sep 15, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 15, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 15, 2022
@awaelchli
Copy link
Contributor

@Blaizzy Do you want to have a quick look here before we merge? 😃

@Blaizzy
Copy link
Contributor

Blaizzy commented Sep 16, 2022

@awaelchli yes, I would like that.

src/pytorch_lightning/loggers/neptune.py Outdated Show resolved Hide resolved
tests/tests_pytorch/loggers/test_neptune.py Outdated Show resolved Hide resolved
@Blaizzy
Copy link
Contributor

Blaizzy commented Sep 16, 2022

@awaelchli

I left a few comments and will also be calling in someone from engineering to double-check the test cases.

But outside of that, I think it looks good.

Next steps:
After the engineer gives the green light 🟢 , we can merge with no problem.

@Blaizzy
Copy link
Contributor

Blaizzy commented Sep 16, 2022

@awaelchli, the review is done 👍

Any questions about the changes requested, please tag me and @shnela directly. We are here to help you with anything you might need.

@carmocca carmocca enabled auto-merge (squash) September 16, 2022 15:43
@carmocca carmocca merged commit 8c01c89 into master Sep 16, 2022
@carmocca carmocca deleted the refactor/remove-deprecated-neptune-code branch September 16, 2022 16:26
rohitgr7 pushed a commit that referenced this pull request Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logger: neptune pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants