Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the setter in the children recursively #14724

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Use the setter in the children recursively #14724

merged 2 commits into from
Sep 15, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 15, 2022 •
edited
Loading

What does this PR do?

Follow-up to #14657. Copy pasting made me not call the setter recursively

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added bug Something isn't working pl Generic label for PyTorch Lightning package labels Sep 15, 2022
@carmocca carmocca added this to the pl:1.7.x milestone Sep 15, 2022
@carmocca carmocca self-assigned this Sep 15, 2022
@carmocca carmocca changed the title Use the setter in the children Use the setter in the children recursively Sep 15, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 15, 2022
@carmocca carmocca enabled auto-merge (squash) September 15, 2022 12:03
@carmocca carmocca merged commit 5ff78f0 into master Sep 15, 2022
@carmocca carmocca deleted the bugfix/torchscript-recursive-2 branch September 15, 2022 13:58
kaushikb11 pushed a commit that referenced this pull request Sep 21, 2022
@carmocca @kaushikb11
Use the setter in the children recursively (#14724)
373a0e9
carmocca added a commit that referenced this pull request Sep 21, 2022
@carmocca
Use the setter in the children recursively (#14724)
8fab6cf
lexierule pushed a commit that referenced this pull request Sep 22, 2022
@carmocca @lexierule
Use the setter in the children recursively (#14724)
1649422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@krshrimali krshrimali krshrimali approved these changes

@justusschock justusschock justusschock approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@otaj otaj Awaiting requested review from otaj

Assignees

@carmocca carmocca

Labels
bug Something isn't working pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
pl:1.7.x
Development

Successfully merging this pull request may close these issues.
6 participants
@carmocca @awaelchli @Borda @justusschock @krshrimali @rohitgr7