Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix neptune-client package available detection #14714

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 15, 2022

What does this PR do?

Fixes #14695

This targets the release/pytorch branch!

Discussed with @carmocca that my immediate fix can directly go to the release branch for the next patch. Note that we don't have the lightning-utilities dependency for this branch.
Meanwhile, @carmocca will push the proper fix to master in #14715 and follow up.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @tchaton @rohitgr7 @Blaizzy @akihironitta

@awaelchli awaelchli added this to the pl:1.7.x milestone Sep 15, 2022
@awaelchli awaelchli added the priority: 0 High priority task label Sep 15, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 15, 2022
@awaelchli awaelchli added bug Something isn't working and removed pl Generic label for PyTorch Lightning package labels Sep 15, 2022
@awaelchli awaelchli marked this pull request as ready for review September 15, 2022 09:56
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 15, 2022
@mergify mergify bot removed the has conflicts label Sep 15, 2022
@awaelchli awaelchli changed the base branch from master to release/pytorch September 16, 2022 12:39
@awaelchli awaelchli changed the base branch from release/pytorch to master September 16, 2022 12:40
@awaelchli awaelchli force-pushed the bugfix/neptune-available branch from 990eac4 to 5095700 Compare September 16, 2022 17:35
@awaelchli awaelchli requested a review from lantiga as a code owner September 16, 2022 17:35
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Sep 16, 2022
@awaelchli awaelchli changed the base branch from master to release/pytorch September 16, 2022 17:35
@mergify mergify bot removed the has conflicts label Sep 16, 2022
@awaelchli awaelchli self-assigned this Sep 16, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 16, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 16, 2022
@awaelchli awaelchli force-pushed the bugfix/neptune-available branch from 37ca735 to 7c244a7 Compare September 17, 2022 22:06
@awaelchli
Copy link
Contributor Author

@Borda @carmocca

Quick notice:

Is it ok if we rebase-merge it like this? Or do you have a different preference?

@carmocca
Copy link
Contributor

It is okay

@lexierule lexierule merged commit 39f899a into release/pytorch Sep 19, 2022
@lexierule lexierule deleted the bugfix/neptune-available branch September 19, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logger: neptune pl Generic label for PyTorch Lightning package priority: 0 High priority task ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unable to use neptune logger after a version upgrade of pytorch lightning
4 participants