Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReduceLROnPlateau update issue while resuming from a checkpoint #14702

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Fix ReduceLROnPlateau update issue while resuming from a checkpoint #14702

merged 1 commit into from
Oct 4, 2022

Conversation

geoffrey-g-delhomme
Copy link
Contributor

@geoffrey-g-delhomme geoffrey-g-delhomme commented Sep 14, 2022 •
edited
Loading

What does this PR do?

Fixes #14699

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 14, 2022
@carmocca carmocca added bug Something isn't working fault tolerance loops Related to the Loop API community This PR is from the community labels Sep 14, 2022
@carmocca carmocca self-assigned this Sep 14, 2022
@carmocca carmocca added this to the pl:1.7.x milestone Sep 14, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 15, 2022
@carmocca carmocca enabled auto-merge (squash) September 15, 2022 13:29
@mergify mergify bot added has conflicts ready PRs ready to be merged and removed ready PRs ready to be merged has conflicts labels Sep 15, 2022
@mergify mergify bot added has conflicts ready PRs ready to be merged and removed ready PRs ready to be merged has conflicts labels Sep 18, 2022
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged has conflicts labels Sep 21, 2022
otaj
otaj approved these changes Sep 22, 2022
View reviewed changes
src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added has conflicts ready PRs ready to be merged and removed ready PRs ready to be merged has conflicts labels Sep 22, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 4, 2022
@carmocca carmocca merged commit 9832d36 into Lightning-AI:master Oct 4, 2022
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
@geoffrey-g-delhomme @carmocca @nicolai86
Fix ReduceLROnPlateau update issue while resuming from a checkpoint (…
9923868 
…#14702)

Co-authored-by: Carlos Mocholí <[email protected]>
@geoffrey-g-delhomme geoffrey-g-delhomme deleted the bug/14699 branch November 4, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 left review comments

@carmocca carmocca carmocca approved these changes

@otaj otaj otaj approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees

@carmocca carmocca

Labels
bug Something isn't working community This PR is from the community fault tolerance loops Related to the Loop API pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.7.x
Development

Successfully merging this pull request may close these issues.

ReduceLROnPlateau update error while resuming from a checkpoint
6 participants
@geoffrey-g-delhomme @awaelchli @Borda @otaj @carmocca @rohitgr7