Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated torch_distributed_backend logic #14693

Merged
merged 8 commits into from
Sep 16, 2022
Merged

Remove deprecated torch_distributed_backend logic #14693

merged 8 commits into from
Sep 16, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 13, 2022 •
edited by Borda
Loading

What does this PR do?

Removes distributed backend logic slated for removal in 1.8.

Does your PR introduce any breaking changes? If yes, please list them.

Yes. The environment variable PL_TORCH_DISTRIBUTED_BACKEND can no longer be used to set the backend (gloo, nccl) and has to be controlled through the code/strategy directly.

resolves #11745

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added deprecation Includes a deprecation breaking change Includes a breaking change strategy labels Sep 13, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 13, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 13, 2022
@awaelchli awaelchli self-assigned this Sep 13, 2022
@awaelchli awaelchli marked this pull request as ready for review September 13, 2022 22:19
carmocca
carmocca approved these changes Sep 14, 2022
View reviewed changes
src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
This was referenced Sep 14, 2022
Merged
Merged
awaelchli added a commit that referenced this pull request Sep 14, 2022
@awaelchli
fix test after deprecated code as in #14693
b9e1a9c
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 15, 2022
@Borda Borda enabled auto-merge (squash) September 15, 2022 17:18
@carmocca carmocca removed the deprecation Includes a deprecation label Sep 16, 2022
tchaton
tchaton approved these changes Sep 16, 2022
View reviewed changes
src/pytorch_lightning/CHANGELOG.md
@@ -171,6 +171,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Removed the deprecated `BaseProfiler` and `AbstractProfiler` classes ([#14404](https://github.com/Lightning-AI/lightning/pull/14404))


- Removed the deprecated way to set the distributed backend via the environment variable `PL_TORCH_DISTRIBUTED_BACKEND`, in favor of setting the `process_group_backend` in the strategy constructor ([#14693](https://github.com/Lightning-AI/lightning/pull/14693))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally would have kept it but otherwise, LGTM !

@Borda Borda merged commit 5bef756 into master Sep 16, 2022
@Borda Borda deleted the refactor/remove-deprecated-pg-backend branch September 16, 2022 15:27
rohitgr7 pushed a commit that referenced this pull request Sep 24, 2022
@awaelchli @Borda @rohitgr7
Remove deprecated torch_distributed_backend logic (#14693)
d532a82 
* Remove deprecated torch_distributed_backend logic
* changelog
* mention deprecated
* imports

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@carmocca carmocca carmocca approved these changes

@otaj otaj otaj approved these changes

@Borda Borda Borda approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@awaelchli awaelchli

Labels
breaking change Includes a breaking change pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@awaelchli @Borda @otaj @carmocca @tchaton