-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to query device count via NVML #14631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that this was fixed!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #14631 +/- ##
=========================================
+ Coverage 84% 85% +1%
=========================================
Files 395 276 -119
Lines 28894 21238 -7656
=========================================
- Hits 24236 18102 -6134
+ Misses 4658 3136 -1522 |
Co-authored-by: Carlos Mocholí <[email protected]>
What does this PR do?
Redo of #14319
Note: This is an enhancement/improvement of the preivous bugfix, not addressing any new bugs.
This adopts the solution in pytorch/pytorch#84879 for Lightning when running with PyTorch < 1.13.
A minor follow-up is still pending: pytorch/pytorch#85024
Validated with nightly pytorch 1.13 locally, using this simple script:
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @akihironitta