Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add easy access to state_dict in Lite module wrapper #14629

Merged
merged 6 commits into from
Sep 14, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 9, 2022

What does this PR do?

Fixes #14571

Breaking change

This is a breaking change for anyone who had to work-around the saving and loading with model.module, or mangling with the raw state-dict keys of model.state_dict().

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli changed the title state dict for Lite module wrapper Add easy access to state_dict in Lite module wrapper Sep 9, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 9, 2022
@awaelchli awaelchli added feature Is an improvement or enhancement breaking change Includes a breaking change fabric lightning.fabric.Fabric labels Sep 9, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 9, 2022
src/pytorch_lightning/lite/wrappers.py Show resolved Hide resolved
src/pytorch_lightning/lite/wrappers.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Sep 12, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 13, 2022
@Borda
Copy link
Member

Borda commented Sep 13, 2022

@awaelchli, mind checking/resolving the remaining conversations? 🦦

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 13, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 13, 2022
@awaelchli awaelchli merged commit 8b3d6d8 into master Sep 14, 2022
@awaelchli awaelchli deleted the lite/state-dict branch September 14, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change fabric lightning.fabric.Fabric feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify state dict access on model wrapper in Lite
5 participants