-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add easy access to state_dict
in Lite module wrapper
#14629
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
changed the title
state dict for Lite module wrapper
Add easy access to Sep 9, 2022
state_dict
in Lite module wrapper
awaelchli
added
feature
Is an improvement or enhancement
breaking change
Includes a breaking change
fabric
lightning.fabric.Fabric
labels
Sep 9, 2022
awaelchli
requested review from
tchaton,
carmocca,
Borda,
justusschock,
rohitgr7,
otaj,
williamFalcon and
kaushikb11
as code owners
September 9, 2022 20:13
awaelchli
commented
Sep 9, 2022
carmocca
approved these changes
Sep 11, 2022
justusschock
approved these changes
Sep 12, 2022
Borda
approved these changes
Sep 12, 2022
rohitgr7
approved these changes
Sep 12, 2022
@awaelchli, mind checking/resolving the remaining conversations? 🦦 |
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Sep 13, 2022
carmocca
reviewed
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
fabric
lightning.fabric.Fabric
feature
Is an improvement or enhancement
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14571
Breaking change
This is a breaking change for anyone who had to work-around the saving and loading with
model.module
, or mangling with the raw state-dict keys ofmodel.state_dict()
.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃