Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate lightning_utilities is_overridden #14620

Merged
merged 6 commits into from
Sep 12, 2022
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 9, 2022

What does this PR do?

Follo-up to Lightning-AI/utilities#35

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca enabled auto-merge (squash) September 9, 2022 12:13
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #14620 (0c2addc) into master (3c23125) will increase coverage by 22%.
The diff coverage is 100%.

❗ Current head 0c2addc differs from pull request most recent head b25c309. Consider uploading reports for the commit b25c309 to get more accurate results

@@            Coverage Diff            @@
##           master   #14620     +/-   ##
=========================================
+ Coverage      64%      85%    +22%     
=========================================
  Files         358      336     -22     
  Lines       27057    26196    -861     
=========================================
+ Hits        17187    22307   +5120     
+ Misses       9870     3889   -5981     

@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Sep 9, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 10, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit e859546 into master Sep 12, 2022
@carmocca carmocca deleted the refactor/is-overridd branch September 12, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants