-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate lightning_utilities is_overridden
#14620
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
tchaton,
awaelchli,
manskx,
hhsecond,
Borda,
williamFalcon,
kaushikb11 and
rohitgr7
as code owners
September 9, 2022 12:11
Codecov Report
@@ Coverage Diff @@
## master #14620 +/- ##
=========================================
+ Coverage 64% 85% +22%
=========================================
Files 358 336 -22
Lines 27057 26196 -861
=========================================
+ Hits 17187 22307 +5120
+ Misses 9870 3889 -5981 |
awaelchli
approved these changes
Sep 9, 2022
Borda
approved these changes
Sep 9, 2022
mergify
bot
added
ready
PRs ready to be merged
has conflicts
and removed
ready
PRs ready to be merged
labels
Sep 9, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Sep 10, 2022
akihironitta
approved these changes
Sep 10, 2022
carmocca
commented
Sep 11, 2022
tchaton
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follo-up to Lightning-AI/utilities#35
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review