Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid warning when cloning tensor in self.log #14599

Merged
merged 11 commits into from
Sep 13, 2022
Merged

Avoid warning when cloning tensor in self.log #14599

merged 11 commits into from
Sep 13, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 8, 2022 •
edited
Loading

What does this PR do?

Fixes #14594

Test fails on master.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli changed the title avoid warning when cloning tensor in self.log Avoid warning when cloning tensor in self.log Sep 8, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 8, 2022
@carmocca carmocca added the bug Something isn't working label Sep 8, 2022
@carmocca carmocca added this to the pl:1.7.x milestone Sep 8, 2022
@awaelchli
Copy link
Contributor Author

@carmocca Since you are code-owner for the logging part, where would you suggest that I insert the test case?

@awaelchli awaelchli marked this pull request as ready for review September 9, 2022 09:12
carmocca
carmocca reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carmocca Since you are code-owner for the logging part, where would you suggest that I insert the test case?

The chosen file is appropriate

tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Sep 9, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 12, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 12, 2022
@awaelchli awaelchli mentioned this pull request Sep 12, 2022
Merged
12 tasks
tchaton
tchaton approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rohitgr7 rohitgr7 merged commit 1ee3d1e into master Sep 13, 2022
@rohitgr7 rohitgr7 deleted the bugfix/log-tensor-clone branch September 13, 2022 10:53
awaelchli added a commit that referenced this pull request Sep 13, 2022
@awaelchli @Borda
Avoid warning when cloning tensor in self.log (#14599)
729e292 
Co-authored-by: Jirka Borovec <[email protected]>
lexierule pushed a commit that referenced this pull request Sep 13, 2022
@awaelchli @Borda @lexierule
Avoid warning when cloning tensor in self.log (#14599)
72f82eb 
Co-authored-by: Jirka Borovec <[email protected]>
@awaelchli awaelchli mentioned this pull request Sep 15, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krshrimali krshrimali krshrimali left review comments

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@tchaton tchaton tchaton approved these changes

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@otaj otaj Awaiting requested review from otaj

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@awaelchli awaelchli

Labels
bug Something isn't working pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
pl:1.7.x
Development

Successfully merging this pull request may close these issues.

UserWarning: use tensor.clone().detach() instead of torch.tensor(tensor)
6 participants
@awaelchli @Borda @carmocca @tchaton @krshrimali @rohitgr7