Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with lightning_utilities.core.enums #14558

Merged
merged 9 commits into from
Sep 7, 2022
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 6, 2022

What does this PR do?

Part of Lightning-AI/utilities#23

I haven't deprecated the LightningEnum import. It can be done in a follow-up

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli @rohitgr7

@carmocca carmocca added this to the pl:1.8 milestone Sep 6, 2022
@carmocca carmocca self-assigned this Sep 6, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 6, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Sep 6, 2022
@carmocca carmocca marked this pull request as ready for review September 6, 2022 17:33
carmocca added a commit that referenced this pull request Sep 7, 2022
@carmocca carmocca enabled auto-merge (squash) September 7, 2022 09:19
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Sep 7, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 7, 2022
@carmocca carmocca merged commit 8c4184c into master Sep 7, 2022
@carmocca carmocca deleted the refactor/strenum branch September 7, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants