-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate lightning_utilities.core.rank_zero
#14556
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
awaelchli
reviewed
Sep 6, 2022
awaelchli
approved these changes
Sep 6, 2022
carmocca
requested review from
williamFalcon,
tchaton,
Borda,
justusschock,
kaushikb11,
rohitgr7,
otaj and
akihironitta
as code owners
September 6, 2022 16:11
akihironitta
approved these changes
Sep 6, 2022
justusschock
approved these changes
Sep 6, 2022
Borda
approved these changes
Sep 6, 2022
tchaton
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
awaelchli
force-pushed
the
refactor/utils-rank-zero
branch
from
September 6, 2022 19:37
b76e757
to
268033d
Compare
awaelchli
force-pushed
the
refactor/utils-rank-zero
branch
from
September 7, 2022 07:27
9871400
to
0432460
Compare
Codecov Report
@@ Coverage Diff @@
## master #14556 +/- ##
========================================
+ Coverage 85% 85% +1%
========================================
Files 347 347
Lines 26865 26814 -51
========================================
+ Hits 22815 22916 +101
+ Misses 4050 3898 -152 |
It is a miracle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #14492
Blocked by Lightning-AI/utilities#36Closes #14572
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
cc @Borda @justusschock @awaelchli @rohitgr7