-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for downloading wandb artifacts in the WandbLogger #14551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out having to access the experiment object
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
manangoel99
requested review from
Borda,
williamFalcon,
tchaton,
awaelchli,
kaushikb11 and
rohitgr7
as code owners
September 6, 2022 05:04
12 tasks
awaelchli
added
logger: wandb
Weights & Biases
feature
Is an improvement or enhancement
community
This PR is from the community
labels
Sep 6, 2022
awaelchli
reviewed
Sep 8, 2022
awaelchli
requested review from
carmocca,
justusschock and
otaj
as code owners
September 9, 2022 10:06
awaelchli
approved these changes
Sep 9, 2022
carmocca
approved these changes
Sep 9, 2022
Borda
approved these changes
Sep 9, 2022
rohitgr7
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
This PR is from the community
feature
Is an improvement or enhancement
logger: wandb
Weights & Biases
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds two functions to the WandbLogger,
download_artifact
anduse_artifact
.The
download_artifact
function downloads the artifact from the given artifact path. If there is an ongoing run, the artifact is automatically linked to the run and otherwise it is just downloaded and stored. It returns the path to the downloaded artifact.The
use_artifact
function links the artifact to the ongoing run and returns awandb.Artifact
object which can then optionally be downloaded by the user.Fixes #11769
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Yes!
Make sure you had fun coding 🙃