Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for downloading wandb artifacts in the WandbLogger #14551

Merged
merged 24 commits into from
Sep 14, 2022
Merged

Added support for downloading wandb artifacts in the WandbLogger #14551

merged 24 commits into from
Sep 14, 2022

Conversation

manangoel99
Copy link
Contributor

What does this PR do?

This PR adds two functions to the WandbLogger, download_artifact and use_artifact.

The download_artifact function downloads the artifact from the given artifact path. If there is an ongoing run, the artifact is automatically linked to the run and otherwise it is just downloaded and stored. It returns the path to the downloaded artifact.

The use_artifact function links the artifact to the ongoing run and returns a wandb.Artifact object which can then optionally be downloaded by the user.

Fixes #11769

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yes!
Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 6, 2022
@awaelchli awaelchli added logger: wandb Weights & Biases feature Is an improvement or enhancement community This PR is from the community labels Sep 6, 2022
test_script.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 8, 2022
@awaelchli awaelchli self-assigned this Sep 9, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 9, 2022
@Borda Borda enabled auto-merge (squash) September 9, 2022 18:51
@Borda Borda disabled auto-merge September 12, 2022 17:37
@Borda Borda enabled auto-merge (squash) September 13, 2022 22:25
@Borda Borda merged commit 48e783d into Lightning-AI:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community feature Is an improvement or enhancement logger: wandb Weights & Biases pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use W&B Dataset and Model Artifacts in Experiments with WandbLogger
6 participants