Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone Lite: Move apply_func utilities #14516

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 3, 2022

What does this PR do?

Moves apply_func utils to Lite standalone package. Requested by reviewer to split out of #14492

Needs to be merged with rebase+merge.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

No. Splitting out changes from a PR that is already splitting out changes from another PR already splitting out changes from the original PR is not fun.

cc @Borda @tchaton @rohitgr7 @carmocca @justusschock @awaelchli @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 3, 2022
@awaelchli awaelchli self-assigned this Sep 3, 2022
@awaelchli awaelchli added fabric lightning.fabric.Fabric priority: 0 High priority task labels Sep 3, 2022
@awaelchli awaelchli marked this pull request as ready for review September 3, 2022 14:02
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 3, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Sep 5, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Sep 5, 2022
@mergify mergify bot added ready PRs ready to be merged and removed ready PRs ready to be merged labels Sep 5, 2022
@awaelchli awaelchli enabled auto-merge (rebase) September 5, 2022 16:37
@awaelchli awaelchli merged commit 7f148b2 into master Sep 5, 2022
@awaelchli awaelchli deleted the lite/apply-func branch September 5, 2022 18:30
@carmocca carmocca mentioned this pull request Sep 6, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package priority: 0 High priority task ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants