Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone Lite: Move xla_device utils #14514

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Standalone Lite: Move xla_device utils #14514

merged 2 commits into from
Sep 5, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 3, 2022

What does this PR do?

Moves xla_device to Lite standalone package. Requested by reviewer to split out of #14492

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @tchaton @rohitgr7 @carmocca @justusschock @awaelchli @akihironitta

@awaelchli awaelchli added priority: 0 High priority task fabric lightning.fabric.Fabric labels Sep 3, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 3, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 3, 2022
@awaelchli awaelchli changed the title Draft Standalone Lite: Move xla_device utils Standalone Lite: Move xla_device utils Sep 3, 2022
@awaelchli awaelchli force-pushed the lite/xla-device branch 2 times, most recently from b0fd31e to 85309cc Compare September 3, 2022 12:43
@awaelchli awaelchli marked this pull request as ready for review September 3, 2022 13:31
@awaelchli awaelchli self-assigned this Sep 3, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 4, 2022
awaelchli added a commit that referenced this pull request Sep 4, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli enabled auto-merge (rebase) September 5, 2022 14:33
@awaelchli awaelchli merged commit 165427a into master Sep 5, 2022
@awaelchli awaelchli deleted the lite/xla-device branch September 5, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package priority: 0 High priority task ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants