-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone Lite: Move xla_device utils #14514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
changed the title
Draft Standalone Lite: Move xla_device utils
Standalone Lite: Move xla_device utils
Sep 3, 2022
awaelchli
force-pushed
the
lite/xla-device
branch
2 times, most recently
from
September 3, 2022 12:43
b0fd31e
to
85309cc
Compare
awaelchli
requested review from
Borda,
tchaton,
carmocca,
justusschock,
rohitgr7,
otaj,
williamFalcon and
kaushikb11
as code owners
September 3, 2022 13:31
carmocca
approved these changes
Sep 4, 2022
justusschock
approved these changes
Sep 4, 2022
awaelchli
added a commit
that referenced
this pull request
Sep 4, 2022
awaelchli
added a commit
that referenced
this pull request
Sep 4, 2022
awaelchli
force-pushed
the
lite/xla-device
branch
from
September 4, 2022 19:43
85309cc
to
a96f303
Compare
kaushikb11
approved these changes
Sep 5, 2022
tchaton
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
rohitgr7
approved these changes
Sep 5, 2022
awaelchli
force-pushed
the
lite/xla-device
branch
from
September 5, 2022 14:32
a96f303
to
7352cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fabric
lightning.fabric.Fabric
pl
Generic label for PyTorch Lightning package
priority: 0
High priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves xla_device to Lite standalone package. Requested by reviewer to split out of #14492
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @tchaton @rohitgr7 @carmocca @justusschock @awaelchli @akihironitta