Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone Lite: Move DeviceDtypeModuleMixin #14511

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 3, 2022

What does this PR do?

Moves DeviceDtypeModuleMixin to Lite standalone package. Requested by reviewer to split out of #14492

Needs to be merged with rebase+merge.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

No. Splitting out changes from a PR that is already splitting out changes from another PR already splitting out changes from the original PR is not fun.

cc @Borda @tchaton @rohitgr7 @carmocca @justusschock @awaelchli @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 3, 2022
@awaelchli awaelchli force-pushed the lite/device-dtype-mixin branch 2 times, most recently from 67032f7 to 71680a7 Compare September 3, 2022 10:38
@awaelchli awaelchli added fabric lightning.fabric.Fabric priority: 0 High priority task labels Sep 3, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 3, 2022
@awaelchli awaelchli force-pushed the lite/device-dtype-mixin branch from 71680a7 to f914336 Compare September 3, 2022 12:16
@awaelchli awaelchli marked this pull request as ready for review September 3, 2022 12:19
@awaelchli awaelchli self-assigned this Sep 3, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 4, 2022
awaelchli added a commit that referenced this pull request Sep 4, 2022
awaelchli added a commit that referenced this pull request Sep 4, 2022
@awaelchli awaelchli force-pushed the lite/device-dtype-mixin branch from f914336 to 3b78c6e Compare September 4, 2022 19:37
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli force-pushed the lite/device-dtype-mixin branch from 3b78c6e to c31b5dc Compare September 5, 2022 13:21
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #14511 (c31b5dc) into master (6773df9) will increase coverage by 28%.
The diff coverage is 46%.

@@            Coverage Diff            @@
##           master   #14511     +/-   ##
=========================================
+ Coverage      60%      88%    +28%     
=========================================
  Files         343      226    -117     
  Lines       26925    19425   -7500     
=========================================
+ Hits        16162    17105    +943     
+ Misses      10763     2320   -8443     

@awaelchli awaelchli merged commit c2879c2 into master Sep 5, 2022
@awaelchli awaelchli deleted the lite/device-dtype-mixin branch September 5, 2022 14:31
awaelchli added a commit that referenced this pull request Sep 5, 2022
awaelchli added a commit that referenced this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package priority: 0 High priority task ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants