-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone Lite: Move DeviceDtypeModuleMixin #14511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
force-pushed
the
lite/device-dtype-mixin
branch
2 times, most recently
from
September 3, 2022 10:38
67032f7
to
71680a7
Compare
awaelchli
force-pushed
the
lite/device-dtype-mixin
branch
from
September 3, 2022 12:16
71680a7
to
f914336
Compare
awaelchli
requested review from
williamFalcon,
tchaton,
carmocca,
Borda,
justusschock,
kaushikb11,
rohitgr7 and
otaj
as code owners
September 3, 2022 12:19
carmocca
approved these changes
Sep 4, 2022
justusschock
approved these changes
Sep 4, 2022
awaelchli
added a commit
that referenced
this pull request
Sep 4, 2022
awaelchli
added a commit
that referenced
this pull request
Sep 4, 2022
awaelchli
added a commit
that referenced
this pull request
Sep 4, 2022
awaelchli
force-pushed
the
lite/device-dtype-mixin
branch
from
September 4, 2022 19:37
f914336
to
3b78c6e
Compare
kaushikb11
approved these changes
Sep 5, 2022
tchaton
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
rohitgr7
approved these changes
Sep 5, 2022
awaelchli
force-pushed
the
lite/device-dtype-mixin
branch
from
September 5, 2022 13:21
3b78c6e
to
c31b5dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #14511 +/- ##
=========================================
+ Coverage 60% 88% +28%
=========================================
Files 343 226 -117
Lines 26925 19425 -7500
=========================================
+ Hits 16162 17105 +943
+ Misses 10763 2320 -8443 |
awaelchli
added a commit
that referenced
this pull request
Sep 5, 2022
awaelchli
added a commit
that referenced
this pull request
Sep 5, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fabric
lightning.fabric.Fabric
pl
Generic label for PyTorch Lightning package
priority: 0
High priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves DeviceDtypeModuleMixin to Lite standalone package. Requested by reviewer to split out of #14492
Needs to be merged with rebase+merge.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
No. Splitting out changes from a PR that is already splitting out changes from another PR already splitting out changes from the original PR is not fun.
cc @Borda @tchaton @rohitgr7 @carmocca @justusschock @awaelchli @akihironitta