-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone Lite: Remaining Utilities #14492
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
changed the base branch from
master
to
refactor/lightning-lite/main
September 2, 2022 00:25
awaelchli
requested review from
williamFalcon,
tchaton,
ananthsub,
carmocca,
Borda,
SkafteNicki,
justusschock,
kaushikb11,
rohitgr7,
otaj and
akihironitta
as code owners
September 2, 2022 08:39
Borda
reviewed
Sep 2, 2022
Borda
reviewed
Sep 2, 2022
awaelchli
changed the base branch from
refactor/lightning-lite/main
to
lite/main
September 2, 2022 09:29
justusschock
approved these changes
Sep 2, 2022
carmocca
reviewed
Sep 2, 2022
carmocca
reviewed
Sep 2, 2022
This was referenced Sep 3, 2022
awaelchli
commented
Sep 7, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Sep 7, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Sep 7, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR moves many utilities that are needed for LightningLite in the standalone package.
Reviewer:
Most of the 200+ files are import changes under
src/pytorch_lightning
. You can skip them in the review and focus on the these items listed here (use the file browser navigation tab):src/lightning_lite/utilities:
All utilities that are related directly to LightningLite, Acclerator, Strategy, etc. were moved here. Subsequent PRs that move the rest of the code will depend on these utilities being in place.src/pytorch_lightning/utilities
: Public utilities that were moved receive a deprecation treatmenttests/tests_lite/helpers
: A subset of testing utils have been copied over from PLtests/tests_lite/utilities
: Tests corresponding to moved functions have been moved heretests/tests_pytorch/utilities
: All code removed here has moved to the corresponding files in tests/tests_lite/utilitiesNotes
TODO(lite)
markers have been added for minor things that need to be resolved in subsequent iterations.cc @Borda @justusschock @awaelchli @rohitgr7 @carmocca @akihironitta