Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate lightning_utilities.core.imports #14475

Merged
merged 12 commits into from
Sep 6, 2022
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Aug 31, 2022

What does this PR do?

See title, these were protected so no deprecations

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli @rohitgr7

@carmocca carmocca added this to the pl:1.8 milestone Aug 31, 2022
@carmocca carmocca self-assigned this Aug 31, 2022
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will think about yet not very sure we want to make this devtool package as base dependency :/
the package was scoped for development, not for production...

requirements/pytorch/base.txt Outdated Show resolved Hide resolved
@carmocca carmocca added app (removed) Generic label for Lightning App package pl Generic label for PyTorch Lightning package labels Aug 31, 2022
@github-actions github-actions bot removed app (removed) Generic label for Lightning App package pl Generic label for PyTorch Lightning package labels Sep 2, 2022
@carmocca carmocca changed the title Integration with devtools Integration with lightning_tools Sep 2, 2022
@carmocca carmocca changed the title Integration with lightning_tools Integration with lightning_utilities Sep 2, 2022
@carmocca carmocca changed the title Integration with lightning_utilities Integrate lightning_utilities.core.imports Sep 5, 2022
requirements/app/base.txt Outdated Show resolved Hide resolved
requirements/pytorch/base.txt Outdated Show resolved Hide resolved
carmocca and others added 2 commits September 6, 2022 12:19
@carmocca carmocca enabled auto-merge (squash) September 6, 2022 10:19
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Sep 6, 2022
requirements/app/base.txt Show resolved Hide resolved
requirements/lite/base.txt Show resolved Hide resolved
requirements/pytorch/base.txt Show resolved Hide resolved
@carmocca carmocca merged commit 44216fd into master Sep 6, 2022
@carmocca carmocca deleted the feat/devtools-integration branch September 6, 2022 12:56
@awaelchli awaelchli mentioned this pull request Oct 25, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants