Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated weights_save_path Trainer argument #14424

Merged
merged 7 commits into from
Sep 12, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 28, 2022

What does this PR do?

Removes

  • Trainer(weights_save_path=...) argument
  • Trainer.weights_save_path property

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @tchaton @rohitgr7 @justusschock @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 28, 2022
@awaelchli awaelchli added deprecation Includes a deprecation breaking change Includes a breaking change and removed pl Generic label for PyTorch Lightning package labels Aug 28, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Aug 28, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 28, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 29, 2022
@carmocca carmocca enabled auto-merge (squash) August 30, 2022 00:00
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 31, 2022
@carmocca carmocca assigned awaelchli and unassigned carmocca Sep 1, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 1, 2022
Copy link
Contributor

@Felonious-Spellfire Felonious-Spellfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit 925edbc into master Sep 12, 2022
@carmocca carmocca deleted the refactor/weights_save_path branch September 12, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change deprecation Includes a deprecation pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants