Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated Trainer.num_processes property in favour of Trainer.num_devices #14423

Merged
merged 7 commits into from
Aug 28, 2022
Merged

Removed deprecated Trainer.num_processes property in favour of Trainer.num_devices #14423

merged 7 commits into from
Aug 28, 2022

Conversation

krishnakalyan3
Copy link
Contributor

@krishnakalyan3 krishnakalyan3 commented Aug 28, 2022

What does this PR do?

Deprecate APIs

resolves #12388

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 28, 2022
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #14423 (7ac851c) into master (1e04951) will increase coverage by 15%.
The diff coverage is n/a.

❗ Current head 7ac851c differs from pull request most recent head d4e75f2. Consider uploading reports for the commit d4e75f2 to get more accurate results

@@            Coverage Diff            @@
##           master   #14423     +/-   ##
=========================================
+ Coverage      61%      76%    +15%     
=========================================
  Files         331      332      +1     
  Lines       26650    26903    +253     
=========================================
+ Hits        16357    20438   +4081     
+ Misses      10293     6465   -3828     

@awaelchli awaelchli changed the title Removed deprecated Trainer.num_processes hook in favour of Trainer.num_devices Removed deprecated Trainer.num_processes property in favour of Trainer.num_devices Aug 28, 2022
@awaelchli awaelchli added deprecation Includes a deprecation breaking change Includes a breaking change labels Aug 28, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Aug 28, 2022
src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 28, 2022
@krishnakalyan3
Copy link
Contributor Author

Thanks for the reviews @rohitgr7 and @awaelchli

@rohitgr7 rohitgr7 enabled auto-merge (squash) August 28, 2022 17:41
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 28, 2022
auto-merge was automatically disabled August 28, 2022 20:33

Head branch was pushed to by a user without write access

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 28, 2022
@carmocca carmocca merged commit 1a3fe39 into Lightning-AI:master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change deprecation Includes a deprecation pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants