-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed deprecated Trainer.num_processes
property in favour of Trainer.num_devices
#14423
Merged
carmocca
merged 7 commits into
Lightning-AI:master
from
krishnakalyan3:dep-expected_num_processes
Aug 28, 2022
Merged
Removed deprecated Trainer.num_processes
property in favour of Trainer.num_devices
#14423
carmocca
merged 7 commits into
Lightning-AI:master
from
krishnakalyan3:dep-expected_num_processes
Aug 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnakalyan3
requested review from
Borda,
awaelchli,
carmocca,
justusschock,
rohitgr7,
otaj,
williamFalcon,
tchaton and
kaushikb11
as code owners
August 28, 2022 08:56
Codecov Report
@@ Coverage Diff @@
## master #14423 +/- ##
=========================================
+ Coverage 61% 76% +15%
=========================================
Files 331 332 +1
Lines 26650 26903 +253
=========================================
+ Hits 16357 20438 +4081
+ Misses 10293 6465 -3828 |
awaelchli
changed the title
Removed deprecated
Removed deprecated Aug 28, 2022
Trainer.num_processes
hook in favour of Trainer.num_devices
Trainer.num_processes
property in favour of Trainer.num_devices
awaelchli
added
deprecation
Includes a deprecation
breaking change
Includes a breaking change
labels
Aug 28, 2022
awaelchli
approved these changes
Aug 28, 2022
Co-authored-by: Adrian Wälchli <[email protected]>
rohitgr7
approved these changes
Aug 28, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Aug 28, 2022
Thanks for the reviews @rohitgr7 and @awaelchli |
auto-merge was automatically disabled
August 28, 2022 20:33
Head branch was pushed to by a user without write access
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
deprecation
Includes a deprecation
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecate APIs
resolves #12388
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃