Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the deprecated Trainer.data_parallel_device_ids function in favour of Trainer.device_ids #14422

Merged
merged 5 commits into from
Aug 28, 2022
Merged

Removed the deprecated Trainer.data_parallel_device_ids function in favour of Trainer.device_ids #14422

merged 5 commits into from
Aug 28, 2022

Conversation

krishnakalyan3
Copy link
Contributor

@krishnakalyan3 krishnakalyan3 commented Aug 28, 2022

What does this PR do?

Removes deprecated APIs.

resolves #12072

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 28, 2022
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #14422 (3108d6a) into master (1e04951) will increase coverage by 14%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #14422     +/-   ##
=========================================
+ Coverage      61%      76%    +14%     
=========================================
  Files         331      331             
  Lines       26650    26687     +37     
=========================================
+ Hits        16357    20233   +3876     
+ Misses      10293     6454   -3839     

@awaelchli awaelchli changed the title Removed the depricated Trainer.data_parallel_device_ids function in favour of Trainer.device_ids Removed the deprecated Trainer.data_parallel_device_ids function in favour of Trainer.device_ids Aug 28, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Aug 28, 2022
@awaelchli awaelchli added breaking change Includes a breaking change deprecation Includes a deprecation labels Aug 28, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 28, 2022
@krishnakalyan3
Copy link
Contributor Author

Thank you for the reviews @rohitgr7 and @awaelchli

@rohitgr7 rohitgr7 enabled auto-merge (squash) August 28, 2022 17:42
@rohitgr7 rohitgr7 merged commit 5cbe1f4 into Lightning-AI:master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change deprecation Includes a deprecation pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants