Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the broken and unused get_deprecated_arg_names #14415

Merged
merged 3 commits into from
Aug 29, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Aug 26, 2022

What does this PR do?

Follow-up to #13693 (comment)

For the historians, this was added in #1147

Does your PR introduce any breaking changes? If yes, please list them.

Removes the broken and unused method.

No public usage: https://grep.app/search?q=get_deprecated_arg_names

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @justusschock @awaelchli @rohitgr7 @Borda

@carmocca carmocca added refactor argparse (removed) Related to argument parsing (argparse, Hydra, ...) breaking change Includes a breaking change labels Aug 26, 2022
@carmocca carmocca added this to the pl:1.8 milestone Aug 26, 2022
@carmocca carmocca self-assigned this Aug 26, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #14415 (5c74d9d) into master (d4bcafa) will increase coverage by 25%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #14415     +/-   ##
=========================================
+ Coverage      51%      76%    +25%     
=========================================
  Files         332      332             
  Lines       26890    26915     +25     
=========================================
+ Hits        13786    20451   +6665     
+ Misses      13104     6464   -6640     

@carmocca carmocca enabled auto-merge (squash) August 29, 2022 12:46
@mergify mergify bot added the ready PRs ready to be merged label Aug 29, 2022
@carmocca carmocca merged commit f202e84 into master Aug 29, 2022
@carmocca carmocca deleted the refactor/remove-broken-code branch August 29, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argparse (removed) Related to argument parsing (argparse, Hydra, ...) breaking change Includes a breaking change pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants