Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the deprecated the trainer.lr_schedulers #14408

Merged
merged 6 commits into from
Aug 28, 2022
Merged

Removed the deprecated the trainer.lr_schedulers #14408

merged 6 commits into from
Aug 28, 2022

Conversation

krishnakalyan3
Copy link
Contributor

@krishnakalyan3 krishnakalyan3 commented Aug 26, 2022 •
edited by Borda
Loading

Removed trainer.lr_schedulers for 1.8 release.
resolves #11443

@krishnakalyan3 krishnakalyan3 marked this pull request as draft August 26, 2022 12:49
@krishnakalyan3 krishnakalyan3 marked this pull request as ready for review August 26, 2022 12:55
@krishnakalyan3
Copy link
Contributor Author

Thanks @rohitgr7 for fixing the change log

@krishnakalyan3 krishnakalyan3 changed the title Deprecated the lr_schedulers in Trainer module Removed the deprecated the trainer.lr_schedulers Aug 26, 2022
@awaelchli awaelchli added breaking change Includes a breaking change pl Generic label for PyTorch Lightning package labels Aug 26, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Aug 26, 2022
awaelchli
awaelchli approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I suggest to keep the checklist from the PR template next time

@mergify mergify bot added the ready PRs ready to be merged label Aug 26, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 26, 2022
@mergify mergify bot removed the has conflicts label Aug 28, 2022
@mergify mergify bot added ready PRs ready to be merged and removed ready PRs ready to be merged labels Aug 28, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) August 28, 2022 17:42
@rohitgr7 rohitgr7 merged commit cea9a72 into Lightning-AI:master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@akihironitta akihironitta akihironitta approved these changes

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@otaj otaj Awaiting requested review from otaj

Assignees
No one assigned
Labels
breaking change Includes a breaking change pl Generic label for PyTorch Lightning package ready PRs ready to be merged trainer
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@krishnakalyan3 @awaelchli @carmocca @akihironitta @rohitgr7