Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated BaseProfiler and AbstractProfiler #14404

Merged
merged 6 commits into from
Sep 13, 2022

Conversation

otaj
Copy link
Contributor

@otaj otaj commented Aug 26, 2022

What does this PR do?

Removes deprecated BaseProfiler and AbstractProfiler

resolves #12150

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7 @justusschock

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 26, 2022
@otaj otaj added this to the pl:1.8 milestone Aug 26, 2022
@otaj otaj self-assigned this Aug 26, 2022
@otaj otaj added the deprecation Includes a deprecation label Aug 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 26, 2022
@awaelchli awaelchli added breaking change Includes a breaking change and removed ready PRs ready to be merged labels Aug 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 26, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 26, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 12, 2022
@akihironitta akihironitta added profiler and removed deprecation Includes a deprecation labels Sep 12, 2022
@otaj otaj enabled auto-merge (squash) September 13, 2022 12:15
@otaj otaj merged commit 6163048 into master Sep 13, 2022
@otaj otaj deleted the deprecated/remove_base_profiler branch September 13, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change pl Generic label for PyTorch Lightning package profiler ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants