Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto wrapping support for DDPFullyShardedStrategy #14383

Merged
merged 15 commits into from
Sep 5, 2022
Merged

Add auto wrapping support for DDPFullyShardedStrategy #14383

merged 15 commits into from
Sep 5, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Aug 24, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Follow-up of #14252
adds auto wrapping for fairscale's FSDP.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @awaelchli @rohitgr7 @akihironitta

@rohitgr7 rohitgr7 added feature Is an improvement or enhancement strategy: fairscale fsdp (removed) Fully Sharded Data Parallel labels Aug 24, 2022
@rohitgr7 rohitgr7 added this to the pl:1.8 milestone Aug 24, 2022
@rohitgr7 rohitgr7 self-assigned this Aug 24, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 24, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review August 26, 2022 07:31
@rohitgr7 rohitgr7 force-pushed the feat/auto_wrap_fsdp_f branch from 94aab61 to 84adb6e Compare August 26, 2022 14:31
@mergify mergify bot removed the has conflicts label Aug 26, 2022
@mergify mergify bot removed the has conflicts label Sep 2, 2022
awaelchli
awaelchli approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work discovering and handling these edge cases!

docs/source-pytorch/advanced/model_parallel.rst Outdated Show resolved Hide resolved
carmocca
carmocca approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Looking forward to those followups

src/pytorch_lightning/strategies/fully_sharded.py Show resolved Hide resolved
src/pytorch_lightning/strategies/fully_sharded.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Sep 2, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) September 5, 2022 10:40
@rohitgr7 rohitgr7 merged commit 8c6119f into master Sep 5, 2022
@rohitgr7 rohitgr7 deleted the feat/auto_wrap_fsdp_f branch September 5, 2022 19:07
@awaelchli awaelchli mentioned this pull request Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@otaj otaj Awaiting requested review from otaj

@edenlightning edenlightning Awaiting requested review from edenlightning

@Felonious-Spellfire Felonious-Spellfire Awaiting requested review from Felonious-Spellfire

Assignees

@rohitgr7 rohitgr7

Labels
feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: fairscale fsdp (removed) Fully Sharded Data Parallel
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@rohitgr7 @awaelchli @carmocca