Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for the deprecated torchtext legacy #14375

Merged
merged 7 commits into from
Aug 26, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Aug 23, 2022

What does this PR do?

Remove support for the deprecated torchtext legacy abstractions
Remove the torchtext dependency

Does your PR introduce any breaking changes? If yes, please list them.

Removes deprecated code

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @Borda @justusschock @awaelchli @rohitgr7

@carmocca carmocca added ci Continuous Integration refactor breaking change Includes a breaking change pl Generic label for PyTorch Lightning package labels Aug 23, 2022
@carmocca carmocca added this to the pl:1.8 milestone Aug 23, 2022
@carmocca carmocca self-assigned this Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #14375 (bdcbaa4) into master (70fe0ed) will decrease coverage by 3%.
The diff coverage is 100%.

❗ Current head bdcbaa4 differs from pull request most recent head ac3525c. Consider uploading reports for the commit ac3525c to get more accurate results

@@            Coverage Diff             @@
##           master   #14375      +/-   ##
==========================================
- Coverage      79%      76%      -3%     
==========================================
  Files         111      332     +221     
  Lines        7258    26867   +19609     
==========================================
+ Hits         5740    20407   +14667     
- Misses       1518     6460    +4942     

@mergify mergify bot added the ready PRs ready to be merged label Aug 24, 2022
@carmocca carmocca enabled auto-merge (squash) August 26, 2022 10:23
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 26, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 26, 2022
@carmocca carmocca merged commit 3ba0f56 into master Aug 26, 2022
@carmocca carmocca deleted the refactor/remove-deprecated-torchtext branch August 26, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ci Continuous Integration pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants