-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for the deprecated torchtext legacy #14375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
ci
Continuous Integration
refactor
breaking change
Includes a breaking change
pl
Generic label for PyTorch Lightning package
labels
Aug 23, 2022
carmocca
requested review from
williamFalcon,
tchaton,
awaelchli,
ananthsub,
Borda,
akihironitta,
kaushikb11 and
rohitgr7
as code owners
August 23, 2022 23:03
Codecov Report
@@ Coverage Diff @@
## master #14375 +/- ##
==========================================
- Coverage 79% 76% -3%
==========================================
Files 111 332 +221
Lines 7258 26867 +19609
==========================================
+ Hits 5740 20407 +14667
- Misses 1518 6460 +4942 |
awaelchli
approved these changes
Aug 24, 2022
otaj
approved these changes
Aug 24, 2022
akihironitta
approved these changes
Aug 24, 2022
rohitgr7
approved these changes
Aug 25, 2022
Borda
approved these changes
Aug 26, 2022
carmocca
commented
Aug 26, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Aug 26, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
ci
Continuous Integration
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove support for the deprecated torchtext legacy abstractions
Remove the torchtext dependency
Does your PR introduce any breaking changes? If yes, please list them.
Removes deprecated code
Before submitting
PR review
cc @carmocca @akihironitta @Borda @justusschock @awaelchli @rohitgr7