-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset dataloaders on failure in tuner #14372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
changed the title
Reset dataloaders on failure in tuner
[Blocked by #13846) Reset dataloaders on failure in tuner
Aug 23, 2022
rohitgr7
changed the title
[Blocked by #13846) Reset dataloaders on failure in tuner
Reset dataloaders on failure in tuner
Aug 26, 2022
rohitgr7
requested review from
SkafteNicki,
Borda,
awaelchli,
carmocca,
justusschock,
otaj,
williamFalcon,
tchaton and
kaushikb11
as code owners
August 26, 2022 09:37
carmocca
reviewed
Aug 26, 2022
carmocca
approved these changes
Aug 26, 2022
awaelchli
approved these changes
Aug 31, 2022
rohitgr7
commented
Aug 31, 2022
12 tasks
krshrimali
pushed a commit
that referenced
this pull request
Sep 13, 2022
krshrimali
pushed a commit
that referenced
this pull request
Sep 13, 2022
lexierule
pushed a commit
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11299
Fixes #14361
Fixes #9625
Closes #12271
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @akihironitta @Borda @rohitgr7