Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset dataloaders on failure in tuner #14372

Merged
merged 7 commits into from
Aug 31, 2022
Merged

Reset dataloaders on failure in tuner #14372

merged 7 commits into from
Aug 31, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Aug 23, 2022

What does this PR do?

Fixes #11299
Fixes #14361
Fixes #9625
Closes #12271

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @akihironitta @Borda @rohitgr7

@rohitgr7 rohitgr7 added bug Something isn't working tuner labels Aug 23, 2022
@rohitgr7 rohitgr7 added this to the pl:1.7.x milestone Aug 23, 2022
@rohitgr7 rohitgr7 self-assigned this Aug 23, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 23, 2022
@rohitgr7 rohitgr7 changed the title Reset dataloaders on failure in tuner [Blocked by #13846) Reset dataloaders on failure in tuner Aug 23, 2022
@rohitgr7 rohitgr7 changed the title [Blocked by #13846) Reset dataloaders on failure in tuner Reset dataloaders on failure in tuner Aug 26, 2022
@rohitgr7 rohitgr7 requested a review from carmocca August 26, 2022 13:29
src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Aug 31, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) August 31, 2022 20:05
@rohitgr7 rohitgr7 merged commit e90ac76 into master Aug 31, 2022
@rohitgr7 rohitgr7 deleted the fix/tuner_dl_reset branch August 31, 2022 21:00
@krshrimali krshrimali mentioned this pull request Sep 9, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pl Generic label for PyTorch Lightning package ready PRs ready to be merged tuner
Projects
None yet
3 participants